the macro "PixelAligned" has some mistake

[flyue]

After my test, the macro
"#define PixelAligned(x)( (float)(int)(( x ) + (( x ) > 0.0f ? 0.5f : -0.5f)) )"
is wrong. The right should be:
"#define PixelAligned(x)((float)((x) + ((x) >= 0.0f ? 0.5f : -0.5f)))"

[CrazyEddie]

I do not have time to check the results of switching the comparison operator, but having said this, removal of the integer cast part is definitely a mistake - without this the macro ceases to perform the intended operation. Since I believe that getting a "correct" result when using the >= over the > probably requires the integer cast to be removed, this whole 'fix' is completely worthless.

Perhaps you could post some relevant information - such as some values passed in, the results you're getting out, the results you think you should have received, and why you believe the ones you're getting are incorrect?



CE

[flyue]

Thank you very much for the reply, although my English is not very good

now I am reading your CEGUI source code, I learned a lot of new techniques from it.

In China, there are many video games use CEGUI , so I'm learning it now.

[CrazyEddie]

In China, there are many video games use CEGUI

It is good to hear that CEGUI is getting used for games in China. I hope you also have success in your learning and use of the library

CE.